Merged
Conversation
jmatsu
reviewed
Jan 15, 2019
| system('open', url) if Commands::Deploy::Push.openable? | ||
| end | ||
| puts '' | ||
| return if error.kind_of?(DeployGate::RavenIgnoreException) |
Contributor
There was a problem hiding this comment.
READMEで「Sentryで送るよ」と書き、また環境変数で送信できないようにするとかの仕組みを入れた方が誠実な気がします 🤔 DISABLE_DEPLOYGATE_CLI_SENTRY とかですかね
Member
Author
There was a problem hiding this comment.
@jmatsu
ありがとうございます！
やはり自動でSentryにローカルの情報を送るのは誠実ではないですね
だとすると
- 提案してくれた方法
- Sentryにエラーを送るときに送ってもいいか聞く
のどちらかかなと考えているのですが、2の方はやり過ぎですかね？
Contributor
There was a problem hiding this comment.
GDPRとかそっちの考え方的には「収集はopt-in/outできること」なので、2なら安心安全ですね 👍
Member
Author
There was a problem hiding this comment.
では強めに2の方で行きます！ありがとうございます！
Member
Author
|
@jmatsu |
Member
Author
|
ありがとうございます！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed GithubIssueRequest, because we can not manage large numbers of errors by type on GitHub issues.
Sending an error to Sentry as an alternative.